Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gnome agility courses #572

Merged
merged 7 commits into from
Dec 29, 2024
Merged

Add gnome agility courses #572

merged 7 commits into from
Dec 29, 2024

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Dec 29, 2024 •
edited
Loading

  • Add gnome basic and advanced courses Agility #484
  • Add gnome trainers with insults and agile legs reward

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 29, 2024 •
edited
Loading

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@codecov Codecov
Copy link

codecov bot commented Dec 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.28926% with 84 lines in your changes missing coverage. Please review.

Project coverage is 34.15%. Comparing base (5ae1b8f) to head (c8f864e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rld/activity/skill/agility/course/GnomeTrainer.kts 2.43% 40 Missing ⚠️
.../activity/skill/agility/course/GnomeStronghold.kts 75.92% 14 Missing and 12 partials ⚠️
...ld/activity/skill/agility/course/GnomeAdvanced.kts 88.88% 3 Missing and 5 partials ⚠️
...ps/engine/entity/character/player/PlayerVisuals.kt 0.00% 4 Missing ⚠️
...orld/activity/skill/agility/course/GnomeAgility.kt 78.57% 2 Missing and 1 partial ⚠️
...dps/world/command/debug/PlayerUpdatingCommands.kts 0.00% 2 Missing ⚠️
...ntity/character/mode/move/target/TargetStrategy.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ntity/character/mode/move/target/TargetStrategy.kt 57.69% <0.00%> (-2.31%) ⬇️
...dps/world/command/debug/PlayerUpdatingCommands.kts 1.09% <0.00%> (ø)
...orld/activity/skill/agility/course/GnomeAgility.kt 78.57% <78.57%> (ø)
...ps/engine/entity/character/player/PlayerVisuals.kt 19.44% <0.00%> (-0.85%) ⬇️
...ld/activity/skill/agility/course/GnomeAdvanced.kts 88.88% <88.88%> (ø)
.../activity/skill/agility/course/GnomeStronghold.kts 75.92% <75.92%> (ø)
...rld/activity/skill/agility/course/GnomeTrainer.kts 2.43% <2.43%> (ø)

... and 4 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #572      +/-   ##
============================================
+ Coverage     33.99%   34.15%   +0.15%     
- Complexity     4804     4806       +2     
============================================
  Files          1319     1323       +4     
  Lines         45873    46112     +239     
  Branches       9337     9369      +32     
============================================
+ Hits          15596    15749     +153     
- Misses        26977    27043      +66     
- Partials       3300     3320      +20
Components Coverage Δ
Content 27.36% <66.66%> (+0.35%) ⬆️
Engine 43.19% <0.00%> (-0.02%) ⬇️
Network 70.69% <ø> (ø)

@GregHib GregHib merged commit 56bcaa6 into main Dec 29, 2024
5 checks passed
@GregHib GregHib deleted the gnome-agility branch December 29, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GregHib